Skip to content

Issue with pymanopt #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguelgfierro merged 3 commits into from
Jan 12, 2022
Merged

Issue with pymanopt #1606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d638461
:bug:
miguelgfierro Jan 10, 2022
48aab47
:bug:
miguelgfierro Jan 11, 2022
5134acc
trigger tests
miguelgfierro Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions SETUP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ This document describes how to setup all the dependencies to run the notebooks i
* [Azure Databricks](https://azure.microsoft.com/en-us/services/databricks/)
* Docker container


## Table of Contents

- [Compute environments](#compute-environments)
Expand Down Expand Up @@ -397,7 +396,7 @@ You can then open the Jupyter notebook server at http://localhost:8888

The process of making a new release and publishing it to pypi is as follows:

First make sure that the tag that you want to add, e.g. `0.6.0`, is added in [recommenders.py/`__init__.py`](recommenders.py/__init__.py). Follow the [contribution guideline](CONTRIBUTING.md) to add the change.
First make sure that the tag that you want to add, e.g. `0.6.0`, is added in [`recommenders.py/__init__.py`](recommenders.py/__init__.py). Follow the [contribution guideline](CONTRIBUTING.md) to add the change.

1. Make sure that the code in main passes all the tests (unit and nightly tests).
1. Create a tag with the version number: e.g. `git tag -a 0.6.0 -m "Recommenders 0.6.0"`.
Expand Down
1 change: 1 addition & 0 deletions tests/integration/examples/test_notebooks_python.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,7 @@ def test_cornac_bpr_integration(


@pytest.mark.integration
@pytest.mark.experimental
Copy link
Contributor

@laserprec laserprec Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't been following some of the latest code changes, but do we have this new pytest.marker defined anywhere in our configuration?

Copy link
Collaborator Author

@miguelgfierro miguelgfierro Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right now there is no pipeline for the experimental, as we improve the dependency installation, we will put back some of the tests in the normal pipeline (cpu, gpu or spark). Also, see #1606 (comment)

@pytest.mark.parametrize(
"expected_values",
[({"rmse": 0.4969, "mae": 0.4761})],
Expand Down