Remove explicit mapping of ratings to integers from RBM notebooks#1585
Merged
miguelgfierro merged 4 commits intostagingfrom Dec 17, 2021
Merged
Remove explicit mapping of ratings to integers from RBM notebooks#1585miguelgfierro merged 4 commits intostagingfrom
miguelgfierro merged 4 commits intostagingfrom
Conversation
pradnyeshjoshi
requested review from
gramhagen,
loomlike and
wutaomsft
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Collaborator
Please don't merge into staging yet |
Collaborator
You may merge now. |
Codecov Report
@@ Coverage Diff @@
## staging #1585 +/- ##
===========================================
+ Coverage 61.88% 61.90% +0.01%
===========================================
Files 84 84
Lines 8458 8462 +4
===========================================
+ Hits 5234 5238 +4
Misses 3224 3224
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Collaborator
|
everything is green so I'll merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previous fix (PR #1581) required user ratings to be explicitly mapped to integers in RBM notebooks. This PR implements changes to the current RBM implementation, so that this explicit mapping is not needed. In particular, a lookup table is maintained internally that maps integer indices to their float rating counterparts.
Related Issues
Checklist:
staging branchand not tomain branch.