Zhangya/python diversity metrics #1491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YanZhangADS
requested review from
anargyri,
gramhagen,
loomlike,
miguelgfierro,
wutaomsft and
yueguoguo
as code owners
gramhagen
approved these changes
Aug 4, 2021
Collaborator
gramhagen
left a comment
gramhagen
left a comment
There was a problem hiding this comment.
this looks great to me, nicely done.
| self.train_df = train_df[[col_user, col_item]] | ||
| self.col_user = col_user | ||
| self.col_item = col_item | ||
| self.sim_col = "sim" |
Collaborator
There was a problem hiding this comment.
should this be a constant like DEFAULT_RELEVANCE_COL?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add python version of diversity metrics.
Related Issues
Checklist:
staging branchand not tomain branch.