Conversation
miguelgfierro
requested review from
anargyri,
gramhagen,
loomlike,
wutaomsft and
yueguoguo
as code owners
miguelgfierro
commented
Jun 14, 2021
4 tasks
gramhagen
reviewed
Jun 14, 2021
SETUP.md
Outdated
Comment on lines
345
to
346
| 1. Make sure that the code in main passes all the tests (unit and nightly tests). | ||
| 2. Update the version number in [reco_utils.py/__init__.py](reco_utils.py/__init__.py) |
Collaborator
There was a problem hiding this comment.
don't we need to modify the version from staging?
Suggested change
| 1. Make sure that the code in main passes all the tests (unit and nightly tests). | |
| 2. Update the version number in [reco_utils.py/__init__.py](reco_utils.py/__init__.py) | |
| 1. Start with staging branch (all unit and nightly tests should be green) | |
| 1. Update the version number in [reco_utils.py/__init__.py](reco_utils.py/__init__.py) | |
| 1. Push PR back to staging | |
| 1. Wait for PR to merge to staging | |
| 1. Create new PR from staging to main | |
| 1. Wait for PR to merge to main branch | |
| 1. Check out updated main branch |
Collaborator
Author
There was a problem hiding this comment.
I'll try to come up with something simple
Collaborator
Author
There was a problem hiding this comment.
@gramhagen I made some changes in this part
gramhagen
approved these changes
Jun 15, 2021
anargyri
approved these changes
Jun 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist:
staging branchand not tomain branch.