Skip to content

Added Java v8 reference and install code for MacOS #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguelgfierro merged 3 commits into from
Nov 3, 2020
Merged

Added Java v8 reference and install code for MacOS #1209

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
977dd74
Added Java v8 reference and install code for MacOS
yegorkryukov Sep 29, 2020
15d34fa
Moved java description to another section
yegorkryukov Oct 6, 2020
7416377
Merge branch 'staging' into yegorkryukov/update_setup_guide
miguelgfierro Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions SETUP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,20 @@ which you can use to create the target environment using the Python version 3.6

**NOTE** the `xlearn` package has dependency on `cmake`. If one uses the `xlearn` related notebooks or scripts, make sure `cmake` is installed in the system. The easiest way to install on Linux is with apt-get: `sudo apt-get install -y build-essential cmake`. Detailed instructions for installing `cmake` from source can be found [here](https://cmake.org/install/).

**NOTE** PySpark v2.4.x requires Java version 8.

<details>
<summary><strong><em>Install Java 8 on MacOS</em></strong></summary>
To install Java 8 on MacOS using [asdf](https://github.com/halcyon/asdf-java):

brew install asdf
asdf plugin add Java
asdf install java adoptopenjdk-8.0.265+1
asdf global java adoptopenjdk-8.0.265+1
. ~/.asdf/plugins/java/set-java-home.zsh
Comment on lines +62 to +66
Copy link
Collaborator

@gramhagen gramhagen Sep 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used a mac in a bit, but curious if asdf is needed here vs more direct use of adoptopenjdk?

brew tap AdoptOpenJDK/openjdk
brew cask install adoptopenjdk8

Copy link
Contributor Author

@yegorkryukov yegorkryukov Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried this one more time rn and when I call java -version I get this:

openjdk version "14.0.1" 2020-04-14
OpenJDK Runtime Environment (build 14.0.1+14)
OpenJDK 64-Bit Server VM (build 14.0.1+14, mixed mode, sharing)

Which stops
So I chose asdf the first time because it set environmental variables correctly (or so I think).

I'm happy to use this solution though. What do you think should I do to fix this?

Copy link
Collaborator

@gramhagen gramhagen Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think typically you would run something like this (and add it in .bashrc or .bash_profile)
export JAVA_HOME=$(/usr/libexec/java_home -v1.8);

but if asdf handles installation without extra setup it's fine. Does this require use of z-shell?

Copy link
Collaborator

@gramhagen gramhagen Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loomlike can you test this out on mac and the 2.4.3 / 2.4.5 versioning issues?

Copy link
Contributor Author

@yegorkryukov yegorkryukov Oct 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this require use of z-shell?

zsh is the default shell on Catalina now I believe

Copy link
Collaborator

@gramhagen gramhagen Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow, i'm really falling behind the times in os/x world =)

Copy link
Collaborator

@loomlike loomlike Nov 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gramhagen I tested and everything looks good. Please see my comment in the previous thread.


</details>

Assuming the repo is cloned as `Recommenders` in the local system, to install **a default (Python CPU) environment**:

cd Recommenders
Expand Down