Skip to content

Fix NNI Test Case#1131

Merged
miguelgfierro merged 1 commit intorecommenders-team:stagingfrom
seanytak:seanytak/nni_bug_fix
Jun 30, 2020
Merged

Fix NNI Test Case#1131
miguelgfierro merged 1 commit intorecommenders-team:stagingfrom
seanytak:seanytak/nni_bug_fix

Conversation

@seanytak
Copy link
Contributor

Description

Fixed the NNI test case.
The NNI server returns a json object with a number of escaped characters such as

"finalMetricData":[{"timestamp":1593483585712,"trialJobId":"yr1Mf","parameterId":"0","type":"FINAL","sequence":0,"data":"\"{\\\"rmse\\\": 3.2157589095060417, \\\"default\\\": 0.10604453870625664, \\\"ndcg_at_k\\\": 0.12934821010667147}\""}]

The data in mock_trials for the test case test_get_trials under tests/unit/test_nni_utils.py is now formatted to match NNI.

Related Issues

Fixes #1125

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging and not master.

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks

@miguelgfierro miguelgfierro merged commit 6d10de9 into recommenders-team:staging Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants