Skip to content

Conversation

@yueguoguo
Copy link
Collaborator

Description

  • Update xlearn notebook based on the code review comments
  • Remove the unused code in the Dockerfile

Related Issues

#973

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@yueguoguo
Copy link
Collaborator Author

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@miguelgfierro miguelgfierro merged commit ba2a20d into staging Dec 10, 2019
@miguelgfierro miguelgfierro deleted the le_xlearn branch December 10, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants