Skip to content

Add progressbar in download#44

Merged
sanderpick merged 2 commits intomainfrom
avichalp/improve-download
Jun 11, 2024
Merged

Add progressbar in download#44
sanderpick merged 2 commits intomainfrom
avichalp/improve-download

Conversation

@avichalp
Copy link
Copy Markdown
Collaborator

@avichalp avichalp commented Jun 11, 2024 •
edited
Loading

  • Adds a progress bar when downloading a file using get CLI command
  • Uses new objects API instead of proxy API

fixes #38
depends on recallnet/ipc#86

avichalp added 2 commits June 11, 2024 19:09
@avichalp
Add progressbar in download
2d5977b 
Signed-off-by: avichalp <hi@avichalp.me>
@avichalp
lint
063e8cc 
Signed-off-by: avichalp <hi@avichalp.me>
@avichalp avichalp marked this pull request as ready for review June 11, 2024 11:37
@avichalp avichalp requested a review from sanderpick June 11, 2024 11:37
@avichalp avichalp mentioned this pull request Jun 11, 2024
Merged
sanderpick
sanderpick approved these changes Jun 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sanderpick sanderpick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sanderpick sanderpick merged commit 3351970 into main Jun 11, 2024
@sanderpick sanderpick deleted the avichalp/improve-download branch June 11, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sanderpick sanderpick sanderpick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show download progress (like we do for uploads)

2 participants

@avichalp @sanderpick