Merged
Conversation
sanderpick
force-pushed
the
sander/ethapi-cors2
branch
from
6f9e04f to
8a50873
Compare
Signed-off-by: Sander Pick <sanderpick@gmail.com>
Signed-off-by: Sander Pick <sanderpick@gmail.com>
sanderpick
force-pushed
the
sander/ethapi-cors2
branch
from
8a50873 to
0c85f48
Compare
avichalp
reviewed
Jun 11, 2024
| TOPDOWN_MAX_PROPOSAL_RANGE = { value = "100", condition = { env_not_set = [ | ||
| "TOPDOWN_MAX_PROPOSAL_RANGE", | ||
| ] } } | ||
| TOPDOWN_MAX_CACHE_BLOCKS = { value = "20000", condition = { env_not_set = [ |
Collaborator
There was a problem hiding this comment.
Is this being used to minimize the RPC calls?
Contributor
Author
There was a problem hiding this comment.
ah no, this is unrelated... i added it when exposing adding parent auth token. it exposes the ability to set how many blocks of history can be used in the parent topdown syncer. https://github.com/amazingdatamachine/ipc/blob/d720e6bf2b73017c89d575f6b62580706f7b572f/fendermint/vm/topdown/src/lib.rs#L58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core changes are copied from here: consensus-shipyard/ipc#1021. The upstream PR has some settings tests. I didn't add those here to reduce future merge conflicts.
This also includes some infra script wiring to expose the http auth token and max cache blocks.
Supersedes #71
Fixes #80