fix: include genesis validators in gateway parent validator tracker#249
Merged
sanderpick merged 1 commit intosander/validator-gaterfrom Oct 12, 2024
Merged
fix: include genesis validators in gateway parent validator tracker#249sanderpick merged 1 commit intosander/validator-gaterfrom
sanderpick merged 1 commit intosander/validator-gaterfrom
Conversation
sanderpick
changed the title
tracker Signed-off-by: Sander Pick <[email protected]>
sanderpick
force-pushed
the
sander/fix-join
branch
from
61636a1 to
5bb67a1
Compare
Contributor
Author
|
@avichalp I PR'd this fix upstream here: consensus-shipyard/ipc#1166. They pointed out that it doesn't cover federated mode, but I think we should merge this into our fork for now, as the full fix will take a bit of time, and we only need to worry about collateral mode. We can revert when merging upstream. Mind taking a look? |
avichalp
reviewed
Oct 10, 2024
| echo "" | ||
| # note: this is consistently going to be | ||
| # 0xE6E340D132b5f46d1e472DebcD681B2aBc16e57E for localnet | ||
| # 0xa85233C63b9Ee964Add6F2cffe00Fd84eb32338f for localnet |
Contributor
Author
There was a problem hiding this comment.
not sure, maybe a change to deployment ordering at genesis causes later contracts to shift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging this fix here for now. I will PR upsteam with a more detailed description.