Merged
Conversation
Co-authored-by: Maciej Witowski <maciej.witowski@protocol.ai> Co-authored-by: raulk <raul@protocol.ai>
Co-authored-by: raulk <raul@protocol.ai>
Co-authored-by: raulk <raul@protocol.ai>
Normalizes all methods to carry 2 arguments. Methods not requiring parameters accept a Params type with an empty tuple generic type.
… ETH facade (#1045) This pull request addresses issue #943 by implementing the recording and exporting of JSON-RPC request latency as a Prometheus histogram. This enhancement will provide better insights into the performance of our JSON-RPC endpoints and enable more effective monitoring and alerting.
Fixing some typos I found.
Signed-off-by: Sander Pick <sanderpick@gmail.com>
sanderpick
force-pushed
the
merge-upstream
branch
from
fc5944a to
105f960
Compare
Signed-off-by: Sander Pick <sanderpick@gmail.com>
Signed-off-by: Sander Pick <sanderpick@gmail.com>
sanderpick
force-pushed
the
merge-upstream
branch
11 times, most recently
from
99cbbd4 to
1c424fd
Compare
Signed-off-by: Sander Pick <sanderpick@gmail.com>
sanderpick
force-pushed
the
merge-upstream
branch
from
1c424fd to
674bc45
Compare
Signed-off-by: Sander Pick <sanderpick@gmail.com>
Signed-off-by: Sander Pick <sanderpick@gmail.com>
Contributor
Author
|
Probably goes w/o saying, but I'm not expecting a big review here |
sanderpick
changed the title
dtbuchholz
approved these changes
Oct 2, 2024
Contributor
dtbuchholz
left a comment
dtbuchholz
left a comment
There was a problem hiding this comment.
lgtm. note that i tried running the localnet script but seems to fail when building images...can figure out later tho, don't wanna hold this up
Contributor
Author
you might be missing vars from the new env. here's what i'm using for localnet: Note the capital |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull in upstream changes up to consensus-shipyard/ipc@f150ff9.