Skip to content

Conversation

@kneth
Copy link
Contributor

@kneth kneth commented Aug 18, 2023

What, How & Why?

This closes #6073

☑️ ToDos

  • 📝 Changelog entry
  • [ ] 📝 Compatibility label is updated or copied from previous entry
  • [ ] 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • [ ] 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • [ ] 📱 Check the React Native/other sample apps work if necessary
  • [ ] 💥 Breaking label has been applied or is not necessary

@kneth kneth requested a review from elle-j August 18, 2023 14:27
@cla-bot cla-bot bot added the cla: yes label Aug 18, 2023
@kneth kneth requested a review from takameyer August 18, 2023 14:28
const realm = new Realm({
schema: [ParentSchema, EmbeddedChildSchema],
schemaVersion: 2,
automaticallyHandleBacklinksInMigration: true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Contributor

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Only got a naming related comment.

@kneth kneth requested review from elle-j and takameyer August 23, 2023 17:30
@kneth kneth changed the title Add automatically_handle_backlinks_in_migrations Add migrationOptions.resolveEmbeddedConstraints Aug 23, 2023
Copy link
Contributor

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kneth kneth force-pushed the kneth/expose-automatically_handle_backlinks_in_migrations branch from 62842b1 to 67b1072 Compare August 24, 2023 10:07
@elle-j
Copy link
Contributor

elle-j commented Aug 24, 2023

Addition: Also export MigrationOptions in index.ts and on the Realm namespace.

@kneth kneth force-pushed the kneth/expose-automatically_handle_backlinks_in_migrations branch from 67b1072 to b30c63d Compare August 27, 2023 14:14
@kneth kneth force-pushed the kneth/expose-automatically_handle_backlinks_in_migrations branch from be9e963 to 9ae748e Compare August 29, 2023 15:03
@kneth kneth merged commit bd0a611 into main Aug 30, 2023
@kneth kneth deleted the kneth/expose-automatically_handle_backlinks_in_migrations branch August 30, 2023 07:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Orphaned embedded objects are not deleted when migrating from Object to Embedded Object

4 participants