Various Set fixes and improvements #2296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
changed the title
LaPeste
reviewed
Mar 16, 2021
LaPeste
reviewed
Mar 16, 2021
LaPeste
reviewed
Mar 16, 2021
LaPeste
reviewed
Mar 16, 2021
LaPeste
reviewed
Mar 16, 2021
Contributor
LaPeste
left a comment
LaPeste
left a comment
There was a problem hiding this comment.
On Tests/Realm.Tests/Database/RealmSetTests.cs I went a little faster then the rest, but overall the changes look more then reasonable to me. However, I have a few doubts about the weaving part, so it could be beneficial if at the next PR reviews (Friday) you could spend a few words on the subject.
LaPeste
approved these changes
Mar 17, 2021
- Simplify collection accessors/weaving by having not constructing the unmanaged collections - Fix adding to Dictionary<EmbeddedObject> when the value is null - Implement Object.GetHashCode - Implement custom IEqualityComparer for binary data to match the native behavior - Add tests for Set<Object> and Set<byte[]>
nirinchev
force-pushed
the
ni/sets-again
branch
from
fee01f3 to
3de1a57
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ISet<T>support. Fixes Add ISet<T> support #2099.ISet<RealmObject>andISet<byte[]>. Fixes [Set] Add tests for Set<byte[]/RealmObject/EmbeddedObject> #2211.RealmObjectBase.GetHashCode. Fixes RealmObject should overload GetHashCode #1650.TODO