Skip to content

Conversation

@jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Sep 3, 2024

What, How & Why?

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@jedelbo
Copy link
Contributor Author

jedelbo commented Sep 3, 2024

The added test should match this one: #7987 (comment)
But the test does not fail.
@tgoyne where am I mistaken.

@coveralls-official
Copy link

Pull Request Test Coverage Report for Build jorgen.edelbo_424

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 68 unchanged lines in 16 files lost coverage.
  • Overall coverage increased (+0.005%) to 91.101%

Files with Coverage Reduction New Missed Lines %
src/realm/list.cpp 1 87.37%
src/realm/sort_descriptor.cpp 1 94.06%
src/realm/util/serializer.cpp 1 90.43%
src/realm/object-store/shared_realm.cpp 2 91.9%
src/realm/sync/network/http.hpp 2 82.27%
src/realm/sync/instruction_applier.cpp 3 68.01%
src/realm/sync/noinst/protocol_codec.hpp 3 76.27%
src/realm/util/future.hpp 3 95.94%
test/fuzz_group.cpp 3 47.53%
src/realm/table.cpp 4 90.55%
Totals Coverage Status
Change from base Build 2595: 0.005%
Covered Lines: 217168
Relevant Lines: 238382

💛 - Coveralls

@jedelbo
Copy link
Contributor Author

jedelbo commented Sep 4, 2024

It turns out that the Swift test was verifying the wrong behavior. It would not harm to add this test anyway.

@jedelbo jedelbo requested a review from nicola-cab September 4, 2024 07:28
@jedelbo jedelbo marked this pull request as ready for review September 5, 2024 08:31
@jedelbo jedelbo merged commit f010f73 into master Sep 5, 2024
@jedelbo jedelbo deleted the je/fix-backlink-notifications branch September 5, 2024 08:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants