Skip to content

Content length buffered sink #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WyriHaximus wants to merge 11 commits into from
Closed

Content length buffered sink #70

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
de46fd2
Content length buffered sink
WyriHaximus Sep 27, 2016
c5d3b3e
Promise for the sink
WyriHaximus Sep 27, 2016
c32eebc
Only substr when buffer is longer then expected length
WyriHaximus Sep 27, 2016
b9a4ee5
Target promise versions that support cancelation
WyriHaximus Sep 28, 2016
0a42711
Make the sink cancelable
WyriHaximus Sep 28, 2016
1c3bcd1
Mark sink internal
WyriHaximus Sep 28, 2016
480ac77
Added docblock comment about the sinks purpose
WyriHaximus Sep 28, 2016
21f2728
Listen for request end event
WyriHaximus Sep 28, 2016
c6b8aa4
protected => private
WyriHaximus Sep 28, 2016
0a99efd
Explicitly forcing int, thus removing a check
WyriHaximus Oct 25, 2016
23526de
Require promise `^2.2` for done: https://github.com/reactphp/http/pul…
WyriHaximus Oct 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
"guzzlehttp/psr7": "^1.0",
"react/socket": "^0.4",
"react/stream": "^0.4",
"evenement/evenement": "^2.0"
"evenement/evenement": "^2.0",
"react/promise": "^2.0 || ^1.0"
Copy link

@HonzaMac HonzaMac Sep 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this?

Copy link
Member Author

@WyriHaximus WyriHaximus Sep 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the sink relies on promises and since 2.1 and 1.2 both introduce cancelable promises plus their API is compatible either is required for wider compatibility. When @jsor releases 3.0 I'll have to research it to see how compatible it is to use, and when it is 3.0, 2.1, and 1.2 will be targeted. This lets the decision which version to use up to composer and the project that is requiring this package which to use.

},
"autoload": {
"psr-4": {
Expand Down