Skip to content

ISSUE-189: EventBaseConfig::FEATURE_FDS not supported on Windows #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
inri13666 wants to merge 4 commits into from
Closed

ISSUE-189: EventBaseConfig::FEATURE_FDS not supported on Windows #192

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5504145
ISSUE-189: EventBaseConfig::FEATURE_FDS not supported on Windows
inri13666 Apr 29, 2019
a589951
CR fixes
inri13666 Jul 12, 2019
3e0b01b
CR: Changed alias `EventBaseConfig` to class `EventConfig` in the docs
inri13666 Jul 12, 2019
d5967e4
Removed ".idea" from ".gitignore"
inri13666 Jul 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
composer.lock
phpunit.xml
vendor
.idea
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ single [`run()`](#run) call that is controlled by the user.
* [Install](#install)
* [Tests](#tests)
* [License](#license)
* [Known issues](#known-issues)
* [More](#more)

## Quickstart example
Expand Down Expand Up @@ -704,6 +705,10 @@ $ php vendor/bin/phpunit

MIT, see [LICENSE file](LICENSE).

## Known Issues
* _*pecl-event*_ on Windows is not capable of accepting arbitrary file descriptor types (`EventBaseConfig::FEATURE_FDS`).
Copy link

@ghost ghost Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class is called EventConfig, not EventBaseConfig (that's only the alias in the event loop implementation).

Copy link
Author

@inri13666 inri13666 Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Instead if an user requires this feature, _*libuv*_ should be used. [Related issue](https://github.com/reactphp/event-loop/issues/189)

## More

* See our [Stream component](https://github.com/reactphp/stream) for more
Expand Down
5 changes: 4 additions & 1 deletion src/ExtEventLoop.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ public function __construct()
}

$config = new EventBaseConfig();
$config->requireFeatures(EventBaseConfig::FEATURE_FDS);
// Skip `EventBaseConfig::FEATURE_FDS` due an issue https://github.com/reactphp/event-loop/issues/189
if ('WIN' !== strtoupper(substr(PHP_OS, 0, 3))) {
$config->requireFeatures(EventBaseConfig::FEATURE_FDS);
}

$this->eventBase = new EventBase($config);
$this->futureTickQueue = new FutureTickQueue();
Expand Down