Skip to content

ExtEventLoop: Remove optional EventBaseConfig and make FEATURE_FDS enabled by default #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsor merged 2 commits into from
Mar 13, 2018
Merged

ExtEventLoop: Remove optional EventBaseConfig and make FEATURE_FDS enabled by default #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ddfc7b
ExtEventLoop make FEATURE_FDS enabled by default
WyriHaximus Mar 11, 2018
1b5e939
Removed config as constructor argument
WyriHaximus Mar 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/ExtEventLoop.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,11 @@ final class ExtEventLoop implements LoopInterface
private $signals;
private $signalEvents = array();

public function __construct(EventBaseConfig $config = null)
public function __construct()
{
$config = new EventBaseConfig();
$config->requireFeatures(EventBaseConfig::FEATURE_FDS);

$this->eventBase = new EventBase($config);
$this->futureTickQueue = new FutureTickQueue();
$this->timerEvents = new SplObjectStorage();
Expand Down
8 changes: 1 addition & 7 deletions tests/ExtEventLoopTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,7 @@ public function createLoop($readStreamCompatible = false)
$this->markTestSkipped('ext-event tests skipped because ext-event is not installed.');
}

$cfg = null;
if ($readStreamCompatible) {
$cfg = new \EventConfig();
$cfg->requireFeatures(\EventConfig::FEATURE_FDS);
}

return new ExtEventLoop($cfg);
return new ExtEventLoop();
}

public function createStream()
Expand Down