Skip to content

Forward compatibility with PHPUnit 6 and PHPUnit 5 #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsor merged 2 commits into from
Nov 15, 2017
Merged

Forward compatibility with PHPUnit 6 and PHPUnit 5 #120

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b77fa2
Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase
carusogabriel Nov 13, 2017
d8ae700
Support PHPUnit 5 and 6
carusogabriel Nov 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"php": ">=5.4.0"
},
"require-dev": {
"phpunit/phpunit": "~4.8"
"phpunit/phpunit": "~4.8.35"
},
"suggest": {
"ext-libevent": ">=0.1.0 for LibEventLoop and PHP5 only",
Expand Down
3 changes: 2 additions & 1 deletion tests/TestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@

namespace React\Tests\EventLoop;

use PHPUnit\Framework\TestCase as BaseTestCase;
use React\EventLoop\LoopInterface;

class TestCase extends \PHPUnit_Framework_TestCase
class TestCase extends BaseTestCase
{
protected function expectCallableExactly($amount)
{
Expand Down