chore: specify yarn as package manager and remove unused dependency#1331
Merged
justin808 merged 3 commits intoreactjs:masterfrom Jan 10, 2024
G-Rath:update-package-jsons
Merged
chore: specify yarn as package manager and remove unused dependency#1331justin808 merged 3 commits intoreactjs:masterfrom G-Rath:update-package-jsons
yarn as package manager and remove unused dependency#1331justin808 merged 3 commits intoreactjs:masterfrom
G-Rath:update-package-jsons
Conversation
justin808
approved these changes
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With #1306 landed we now support any of the main package managers which includes for our internal plumbing, and since we're not specifying a package manager
npmis being used by default which is highlighting a peer dependency conflict withreact-transition-group- it turns out that we don't actually need this package anymore so it can just go, but I've also explicitly set thepackageManagerto beyarnsince that is what was being used before.Since this is also touching the
package.jsonfiles, I figured it would be a good time to slip in runningsort-package-jsonfor consistency.Pull Request checklist
Remove this line after checking all the items here. If the item is not applicable to the PR, both check it out and wrap it by
~.Add/update test to cover these changesUpdate documentationUpdate CHANGELOG file