test: update fixture gemfile locks#1302
Merged
justin808 merged 3 commits intoreactjs:masterfrom Aug 29, 2023
G-Rath:update-lockfiles
Merged
test: update fixture gemfile locks#1302justin808 merged 3 commits intoreactjs:masterfrom G-Rath:update-lockfiles
justin808 merged 3 commits intoreactjs:masterfrom
G-Rath:update-lockfiles
Conversation
Collaborator
|
@G-Rath should this get merged? Looks like mainly lockfile updates. |
Contributor
Author
|
Yup yes please! |
Contributor
Author
|
@justin808 that also goes for the shakapacker PRs I've got open btw :) |
Collaborator
|
Thanks @G-Rath! |
This was referenced Jan 1, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As part of shakacode/shakapacker#349 I have to update the lockfiles which would fail due to
mini_racerso I had to regenerate them completely resulting in a failure because of a newer version ofselenium-webdriverbeing used.I figure ultimately this change is useful on its own because it'll impact anyone that needs to regenerate the lockfiles in future, so I might as well do a dedicated PR for it.
Other Information
Pull Request checklist
Add/update test to cover these changesUpdate documentationUpdate CHANGELOG file