Skip to content

fix: building project when source code path contains spaces #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kentcb merged 3 commits into from
Nov 29, 2017
Merged

fix: building project when source code path contains spaces #1539

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f67c89
msbuild doesn't like paths with spaces in PackageOutputPath parameter
robertlyson Nov 20, 2017
1fb0eb0
Merge branch 'develop' into gh-1535
kentcb Nov 24, 2017
c209269
Merge branch 'develop' into gh-1535
kentcb Nov 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.cake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ Task("BuildReactiveUI")
ArgumentCustomization = args => args.Append("/bl:reactiveui-build.binlog")
}
.WithTarget("build;pack")
.WithProperty("PackageOutputPath", MakeAbsolute(Directory(artifactDirectory)).ToString())
.WithProperty("PackageOutputPath", MakeAbsolute(Directory(artifactDirectory)).ToString().Quote())
.WithProperty("TreatWarningsAsErrors", treatWarningsAsErrors.ToString())
.SetConfiguration("Release")
// Due to https://github.com/NuGet/Home/issues/4790 and https://github.com/NuGet/Home/issues/4337 we
Expand Down