Skip to content

Add WhenAnyObservable overloads that combine latest #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghuntley merged 2 commits into from
Nov 1, 2016
Merged

Add WhenAnyObservable overloads that combine latest #1189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2da494
Add WhenAnyObservable overloads that combine latest
kentcb Nov 1, 2016
39e5108
Merge branch 'rxui7-master' into whenanyobservable-combinelatest
ghuntley Nov 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 44 additions & 2 deletions src/ReactiveUI.Tests/ReactiveNotifyPropertyChangedMixinTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
using ReactiveUI.Testing;
using Xunit;
using Microsoft.Reactive.Testing;
using System.Reactive;

#if !MONO
using System.Windows.Controls;
Expand All @@ -22,6 +23,7 @@ public class TestWhenAnyObsViewModel : ReactiveObject
{
public ReactiveCommand<int, int> Command1 { get; set; }
public ReactiveCommand<int, int> Command2 { get; set; }
public ReactiveCommand<string, string> Command3 { get; set; }

ReactiveList<int> myListOfInts;
public ReactiveList<int> MyListOfInts {
Expand All @@ -33,6 +35,7 @@ public TestWhenAnyObsViewModel()
{
Command1 = ReactiveCommand.CreateFromObservable<int, int>(val => Observable.Return(val));
Command2 = ReactiveCommand.CreateFromObservable<int, int>(val => Observable.Return(val));
Command3 = ReactiveCommand.CreateFromObservable<string, string>(val => Observable.Return(val));
}
}

Expand Down Expand Up @@ -603,7 +606,7 @@ public void OFPNamedPropertyTestRepeats()
public class WhenAnyObservableTests
{
[Fact]
public async Task WhenAnyObservableSmokeTest()
public async Task WhenAnyObservableSmokeTestMerging()
{
var fixture = new TestWhenAnyObsViewModel();

Expand All @@ -628,7 +631,33 @@ public async Task WhenAnyObservableSmokeTest()
}

[Fact]
public void WhenAnyWithNullObjectShouldUpdateWhenObjectIsntNullAnymore()
public async Task WhenAnyObservableSmokeTestCombining()
{
var fixture = new TestWhenAnyObsViewModel();

var list = new List<string>();
fixture.WhenAnyObservable(x => x.Command3, x => x.Command1, (s, i) => s + " : " + i)
.Subscribe(list.Add);

Assert.Equal(0, list.Count);

await fixture.Command1.Execute(1);
await fixture.Command3.Execute("foo");
Assert.Equal(1, list.Count);

await fixture.Command1.Execute(2);
Assert.Equal(2, list.Count);

await fixture.Command3.Execute("bar");
Assert.Equal(3, list.Count);

Assert.True(
new[] { "foo : 1", "foo : 2", "bar : 2", }.Zip(list, (expected, actual) => new { expected, actual })
.All(x => x.expected == x.actual));
}

[Fact]
public void WhenAnyObservableWithNullObjectShouldUpdateWhenObjectIsntNullAnymore()
{
var fixture = new TestWhenAnyObsViewModel();
var output = fixture.WhenAnyObservable(x => x.MyListOfInts.CountChanged).CreateCollection();
Expand All @@ -651,6 +680,7 @@ public void NullObservablesDoNotCauseExceptions()
var fixture = new TestWhenAnyObsViewModel();
fixture.Command1 = null;

// these are the overloads of WhenAnyObservable that perform a Merge
fixture.WhenAnyObservable(x => x.Command1).Subscribe();
fixture.WhenAnyObservable(x => x.Command1, x => x.Command1).Subscribe();
fixture.WhenAnyObservable(x => x.Command1, x => x.Command1, x => x.Command1).Subscribe();
Expand All @@ -662,6 +692,18 @@ public void NullObservablesDoNotCauseExceptions()
fixture.WhenAnyObservable(x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1).Subscribe();
fixture.WhenAnyObservable(x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1).Subscribe();
fixture.WhenAnyObservable(x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1).Subscribe();

// these are the overloads of WhenAnyObservable that perform a CombineLatest
fixture.WhenAnyObservable(x => x.Command1, x => x.Command1, (_0, _1) => Unit.Default).Subscribe();
fixture.WhenAnyObservable(x => x.Command1, x => x.Command1, x => x.Command1, (_0, _1, _2) => Unit.Default).Subscribe();
fixture.WhenAnyObservable(x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, (_0, _1, _2, _3) => Unit.Default).Subscribe();
fixture.WhenAnyObservable(x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, (_0, _1, _2, _3, _4) => Unit.Default).Subscribe();
fixture.WhenAnyObservable(x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, (_0, _1, _2, _3, _4, _5) => Unit.Default).Subscribe();
fixture.WhenAnyObservable(x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, (_0, _1, _2, _3, _4, _5, _6) => Unit.Default).Subscribe();
fixture.WhenAnyObservable(x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, (_0, _1, _2, _3, _4, _5, _6, _7) => Unit.Default).Subscribe();
fixture.WhenAnyObservable(x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, (_0, _1, _2, _3, _4, _5, _6, _7, _8) => Unit.Default).Subscribe();
fixture.WhenAnyObservable(x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, (_0, _1, _2, _3, _4, _5, _6, _7, _8, _9) => Unit.Default).Subscribe();
fixture.WhenAnyObservable(x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, x => x.Command1, (_0, _1, _2, _3, _4, _5, _6, _7, _8, _9, _10) => Unit.Default).Subscribe();
}
}

Expand Down
Loading