refactor: use xamarin.mac framework for reactiveui/reactiveui-testing/microsoft-reactive-testing #1185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/microsoft-reactive-testing this resolves three compiler warnings
glennawatson
pushed a commit
that referenced
this pull request
Mar 23, 2019
…/microsoft-reactive-testing (#1185)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
refactor
What is the current behavior? (You can also link to an open issue here)
reactiveui-eventsuses Xamarin.Mac as target framework.reactiveuiuses NET45 as target framework.reactiveui-testinguses NET45 as target framework.Microsoft.Reactive.Testing_Macuses NET45 as target framework.What is the new behavior (if this is a feature change)?
Xamarin.Mac used as target framework for all of above instead of NET45. This resolves a few
msbuildcompiler warnings.Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information: