Remove BindCommand implementation taking Func<TParam>. #1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes reactiveui#1081 by removing the implementation of BindCommand that takes a Func<TParam>. This implementation has never worked - the command parameter was never passed into the IObservable<object> that the binding infrastructure uses to resolve the command parameter. Moreover, it never could work in the fashion advertised. Since it is just a function, there is no way of knowing when to re-evaluate it. Thus, the observable passed into the binding infrastructure can only evaluate the function once, which makes the entire overload pointless.
glennawatson
pushed a commit
that referenced
this pull request
Mar 23, 2019
Remove BindCommand implementation taking Func<TParam>.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.
What is the current behavior? (You can also link to an open issue here)
See #1081.
What is the new behavior (if this is a feature change)?
The
BindCommandoverload taking aFunc<TParam>has been removed. It has never worked, and there is simply no way to reasonably implement it.Does this PR introduce a breaking change?
Yes, insofar as people are using the faulty
BindCommandoverload (in which case it won't be working for them properly anyway)>Please check if the PR fulfills these requirements