Skip to content

Conversation

@Qonstrukt
Copy link
Member

@Qonstrukt Qonstrukt commented Aug 18, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fixes for ReactiveRecyclerViewAdapter and ReactiveRecyclerViewViewHolder.

What is the current behavior? (You can also link to an open issue here)
Binding an inherited type of ViewModel to a ViewHolder doesn't currently raise change notifications, and you aren't able to use any other type of ViewHolder than ReactiveRecyclerViewViewHolder, while the adapter should only depend on IViewFor to work.

What is the new behavior (if this is a feature change)?
Properly call for this.RaiseAndSetIfChanged() when setting a ViewModel.
Allowing the use of any type of RecyclerView.ViewHolder which complies to IViewFor.

Does this PR introduce a breaking change?
Only if someone doesn't expect the change notices to happen, but that's clearly not the way it should work.

Please check if the PR fulfills these requirements

Other information:
I was bored, so I made a PR. ™️

@ghuntley
Copy link
Member

Thanks for the PR @Qonstrukt, could @reactiveui/reviewers-android please review.

@kentcb kentcb mentioned this pull request Oct 29, 2016
@kentcb kentcb closed this in 1a1c53f Oct 29, 2016
@ghuntley ghuntley modified the milestone: 7.0.0 Nov 6, 2016
@ghuntley ghuntley added this to the 7.0.0 milestone Nov 6, 2016
@Qonstrukt Qonstrukt deleted the rxui7-master branch December 12, 2016 13:30
glennawatson pushed a commit that referenced this pull request Mar 23, 2019
bugfix: make ReactiveRecyclerViewAdapter more flexible
@lock lock bot locked and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants