Small bug fixes to ReactiveRecyclerViewAdapter and ViewHolder #1144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fixes for ReactiveRecyclerViewAdapter and ReactiveRecyclerViewViewHolder.
What is the current behavior? (You can also link to an open issue here)
Binding an inherited type of ViewModel to a ViewHolder doesn't currently raise change notifications, and you aren't able to use any other type of ViewHolder than ReactiveRecyclerViewViewHolder, while the adapter should only depend on IViewFor to work.
What is the new behavior (if this is a feature change)?
Properly call for
this.RaiseAndSetIfChanged()when setting a ViewModel.Allowing the use of any type of RecyclerView.ViewHolder which complies to IViewFor.
Does this PR introduce a breaking change?
Only if someone doesn't expect the change notices to happen, but that's clearly not the way it should work.
Please check if the PR fulfills these requirements
Other information:
I was bored, so I made a PR. ™️