-
-
Notifications
You must be signed in to change notification settings - Fork 6
Add IReactiveObject source generator and tests #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f9b1b61
Add IReactiveObject source generator and tests
ChrisPulman 57af3f3
Remove ViewModelTypeName from ReactiveObjectInfo
ChrisPulman 1de168b
Fix typos in documentation and comments
ChrisPulman 1effa56
Update XML doc for ReactiveObject generator test
ChrisPulman ce56bbc
Update summary for ReactiveObjectInfo model
ChrisPulman 826db8d
Fix typo in ReactiveCommand attribute summary
ChrisPulman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
...sts.FromReactiveObject#ReactiveUI.SourceGenerators.IReactiveObjectAttribute.g.verified.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| //HintName: ReactiveUI.SourceGenerators.IReactiveObjectAttribute.g.cs | ||
| // Copyright (c) 2025 .NET Foundation and Contributors. All rights reserved. | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for full license information. | ||
|
|
||
| // <auto-generated/> | ||
| #pragma warning disable | ||
| #nullable enable | ||
| namespace ReactiveUI.SourceGenerators; | ||
|
|
||
| /// <summary> | ||
| /// IReactiveObject Attribute. | ||
| /// </summary> | ||
| /// <seealso cref="System.Attribute" /> | ||
| [global::System.AttributeUsage(global::System.AttributeTargets.Class, AllowMultiple = false, Inherited = false)] | ||
| internal sealed class IReactiveObjectAttribute : global::System.Attribute; | ||
| #nullable restore | ||
| #pragma warning restore |
68 changes: 68 additions & 0 deletions
68
...activeObjectGeneratorTests.FromReactiveObject#TestNs.TestVM.IReactiveObject.g.verified.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| //HintName: TestNs.TestVM.IReactiveObject.g.cs | ||
| // <auto-generated/> | ||
| #pragma warning disable | ||
| #nullable enable | ||
| using System; | ||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.ComponentModel; | ||
| using ReactiveUI; | ||
|
|
||
| namespace TestNs | ||
| { | ||
| /// <summary> | ||
| /// Partial class for the TestVM which contains ReactiveUI IReactiveObject initialization. | ||
| /// </summary> | ||
| public partial class TestVM : IReactiveObject | ||
| { | ||
| private bool _propertyChangingEventsSubscribed; | ||
| private bool _propertyChangedEventsSubscribed; | ||
|
|
||
| /// <inheritdoc/> | ||
| public event PropertyChangingEventHandler? PropertyChanging | ||
| { | ||
| add | ||
| { | ||
| if (!_propertyChangingEventsSubscribed) | ||
| { | ||
| this.SubscribePropertyChangingEvents(); | ||
| _propertyChangingEventsSubscribed = true; | ||
| } | ||
|
|
||
| PropertyChangingHandler += value; | ||
| } | ||
| remove => PropertyChangingHandler -= value; | ||
| } | ||
|
|
||
| /// <inheritdoc/> | ||
| public event PropertyChangedEventHandler? PropertyChanged | ||
| { | ||
| add | ||
| { | ||
| if (!_propertyChangedEventsSubscribed) | ||
| { | ||
| this.SubscribePropertyChangedEvents(); | ||
| _propertyChangedEventsSubscribed = true; | ||
| } | ||
|
|
||
| PropertyChangedHandler += value; | ||
| } | ||
| remove => PropertyChangedHandler -= value; | ||
| } | ||
|
|
||
| [SuppressMessage("Roslynator", "RCS1159:Use EventHandler<T>", Justification = "Long term design.")] | ||
| private event PropertyChangingEventHandler? PropertyChangingHandler; | ||
|
|
||
| [SuppressMessage("Roslynator", "RCS1159:Use EventHandler<T>", Justification = "Long term design.")] | ||
| private event PropertyChangedEventHandler? PropertyChangedHandler; | ||
|
|
||
| /// <inheritdoc/> | ||
| void IReactiveObject.RaisePropertyChanging(PropertyChangingEventArgs args) => | ||
| PropertyChangingHandler?.Invoke(this, args); | ||
|
|
||
| /// <inheritdoc/> | ||
| void IReactiveObject.RaisePropertyChanged(PropertyChangedEventArgs args) => | ||
| PropertyChangedHandler?.Invoke(this, args); | ||
| } | ||
| } | ||
| #nullable restore | ||
| #pragma warning restore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
src/ReactiveUI.SourceGenerator.Tests/UnitTests/ReactiveObjectGeneratorTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| // Copyright (c) 2025 ReactiveUI and contributors. All rights reserved. | ||
| // Licensed to the ReactiveUI and contributors under one or more agreements. | ||
| // The ReactiveUI and contributors licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for full license information. | ||
|
|
||
| using ReactiveUI.SourceGenerators; | ||
|
|
||
| namespace ReactiveUI.SourceGenerator.Tests; | ||
|
|
||
| /// <summary> | ||
| /// Unit tests for the Reactive generator. | ||
| /// </summary> | ||
| [TestFixture] | ||
| public class ReactiveObjectGeneratorTests : TestBase<ReactiveObjectGenerator> | ||
| { | ||
| /// <summary> | ||
| /// Froms the reactive object. | ||
| /// </summary> | ||
| /// <returns>A task to monitor the async.</returns> | ||
| [Test] | ||
| public Task FromReactiveObject() | ||
| { | ||
| // Arrange: Setup the source code that matches the generator input expectations. | ||
| const string sourceCode = """ | ||
| using System; | ||
| using ReactiveUI.SourceGenerators; | ||
| using System.Reactive.Linq; | ||
| namespace TestNs; | ||
|
|
||
| [IReactiveObject] | ||
| public partial class TestVM | ||
| { | ||
| [Reactive] | ||
| private int _test1 = 10; | ||
| } | ||
| """; | ||
|
|
||
| // Act: Initialize the helper and run the generator. Assert: Verify the generated code. | ||
| return TestHelper.TestPass(sourceCode); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
src/ReactiveUI.SourceGenerators.Roslyn/ReactiveObject/Models/ReactiveObjectInfo.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // Copyright (c) 2025 ReactiveUI and contributors. All rights reserved. | ||
| // Licensed to the ReactiveUI and contributors under one or more agreements. | ||
| // The ReactiveUI and contributors licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for full license information. | ||
|
|
||
| namespace ReactiveUI.SourceGenerators.Models; | ||
|
|
||
| /// <summary> | ||
| /// A model with gathered info on a given command method. | ||
ChrisPulman marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| /// </summary> | ||
| internal sealed record ReactiveObjectInfo( | ||
| TargetInfo TargetInfo, | ||
| string ViewModelTypeName); | ||
ChrisPulman marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.