Fix support for classes implementing IReactiveObject without inheriting from ReactiveObject#225
Merged
ChrisPulman merged 1 commit intoreactiveui:mainfrom Apr 24, 2025
Conversation
…ting from ReactiveObject
ChrisPulman
approved these changes
Apr 24, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes bug #224
What is the current behavior?
Build error when the containing class of a property marked with [Reactive] implements IReactiveObject but does not inherit from ReactiveObject
What is the new behavior?
Works with classes implementing IReactiveObject without inheriting from ReactiveObject
What might this PR break?
Nothing
Please check if the PR fulfills these requirements