[Bug]: Partial properties with Reactive or ObservableAsProperty attribute are flagged by RXUISG0016 analyzer

[DarkCloud14]

Describe the bug 🐞

When creating partial properties with Reactive or ObservableAsProperty attribute in a class which is subclass of ReactiveObject the RXUISG0016 analyzer flags these properties and suggests to convert them to Reactive field.

Even for the property using the ObservableAsProperty attribute it suggests to convert it to a field with the Reactive attribute instead of ObservableAsProperty attribute.

Step to reproduce

1. Create a new .NET9 class library project
2. Install the ReactiveUI and ReactiveUI.SourceGenerators packages
3. Write a simple partial class which is a subclass of ReactiveObject
4. Add a partial get-only property with [ObservableAsProperty] attribute and another partial property (get + set) with [Reactive] attribute

public partial class TestClass : ReactiveObject
{
    [ObservableAsProperty]
    public partial int TestObservableValue { get; }

    [Reactive]
    public partial int TestValue { get; set; }
}

5. See that the TestObservableValue and TestValue properties are flagged with RXUISG0016 suggesting to change them to Reactive fields.

Reproduction repository

https://github.com/DarkCloud14/ReactiveUI_AnalyzerIssues

Expected behavior

The RXUISG0016 analyzer should not flag partial properties if they have the Reactive or ObservableAsProperty attribute (IMHO the last one is even wrong or at least using the suggested code fix produces not the code you'd expect).

In addition to this maybe the ReactiveUI analyzer or ReactiveUI.SourceGenerators could flag (or throw an error) standard properties which have the Reactive or ObservableAsProperty attribute as I think nothing will be created from the SourceGenerators and such properties won't work as expected?!

Screenshots 🖼️

No response

IDE

Rider macOS

Operating system

macOS Sequoia 15.3.1

Version

No response

Device

No response

ReactiveUI Version

ReactiveUI 20.1.63, ReactiveUI.SourceGenerators 2.1.1

Additional information ℹ️

No response

[ChrisPulman]

This is a known issue and was improved in #178 a release is pending, thank you for raising this and providing a repo, this is very helpful to aid in resolving issues.

[DarkCloud14]

Ahh sorry, I had a look at #178 before creating this bug report but overlooked the check that was added regarding the ReactiveUI property.

I guess this bug report can then be closed if there isn't any reason from your side to leave it still open.

[glennawatson]

No need to apologise,

As Chris said you provided a additional repo so he could use your checks to additionally check the validity of the fix and we appreciate your help with the well thought out bugs reports.

Just released the new version, do you mind verifying if this solves the issue for you?

[DarkCloud14]

Just tested it and can confirm that the issue is solved with v2.1.8.

Thanks for the quick help and release of a new package containing the fixes!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.