feat: support gRPC and http apis #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change package name for generated code from proto * Move protos to root folder * Add logger * Refactor routes
kushsharma
reviewed
Sep 1, 2021
rohilsurana
reviewed
Sep 1, 2021
rohilsurana
reviewed
Sep 2, 2021
rohilsurana
reviewed
Sep 2, 2021
h4rikris
force-pushed
the
grpc
branch
2 times, most recently
from
d09894a to
467b5a8
Compare
rohilsurana
approved these changes
Sep 7, 2021
kushsharma
reviewed
Sep 8, 2021
Comment on lines
+29
to
+30
| MaxRecvMsgSizeInMB int `default:"10"` | ||
| MaxSendMsgSizeInMB int `default:"10"` |
Member
There was a problem hiding this comment.
I was wondering what if we just set it really big value and forget about it? I see very little value in making this configurable, to be honest?
kushsharma
reviewed
Sep 8, 2021
| var Logger *zap.Logger | ||
|
|
||
| func init() { | ||
| l, err := zap.NewProduction() |
Member
There was a problem hiding this comment.
I have not used zap so correct me if I am wrong, don't we need to initialize it with config level? Or don't we have configurable log levels like debug/warn/etc?
Also, any specific reason we are creating a package level logger object?
Member
Author
There was a problem hiding this comment.
Ya just wanted basic logger. Later will integrate with config object to control log levels.
Member
There was a problem hiding this comment.
We will move to the salt logger soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.