Skip to content

chore(guardian): add filter by created_by #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ravisuhag merged 2 commits into from
Feb 2, 2022
Merged

chore(guardian): add filter by created_by #95

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b48924
chore(guardian): add created_by filter in ListAppeals and ListApprovals
rahmatrhd Jan 19, 2022
0b0dfb7
chore(guardian): add created_by filter in ListApprovals
rahmatrhd Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions odpf/guardian/v1beta1/guardian.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,7 @@ message ListAppealsRequest {
repeated string resource_types = 6;
repeated string resource_urns = 7;
repeated string order_by = 8;
string created_by = 9;
}

message ListAppealsResponse {
Expand Down Expand Up @@ -334,6 +335,7 @@ message CreateAppealResponse {
message ListUserApprovalsRequest {
repeated string statuses = 2;
repeated string order_by = 3;
string account_id = 4;
}

message ListUserApprovalsResponse {
Expand All @@ -344,6 +346,7 @@ message ListApprovalsRequest {
string account_id = 1;
repeated string statuses = 2;
repeated string order_by = 3;
string created_by = 4;
}

message ListApprovalsResponse {
Expand Down