Skip to content

chore(guardian): add approval reason #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ravisuhag merged 2 commits into from
Dec 14, 2021
Merged

chore(guardian): add approval reason #75

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c08834a
chore(guardian): add allowed_account_types field in ProviderConfig
rahmatrhd Dec 13, 2021
2eb1dfd
chore(guardian): add approval reason
rahmatrhd Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions odpf/guardian/v1beta1/guardian.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,7 @@ message UpdateApprovalRequest {

message Action {
string action = 1;
string reason = 2;
}
Action action = 3;
}
Expand Down Expand Up @@ -390,6 +391,7 @@ message ProviderConfig {
repeated Role roles = 4;
}
repeated ResourceConfig resources = 6;
repeated string allowed_account_types = 7;
}

// Provider contains information about external data provider such as BigQuery, Metabase, etc., credentials, policy, and allowed roles
Expand Down Expand Up @@ -516,6 +518,7 @@ message Approval {
Appeal appeal = 9;
google.protobuf.Timestamp created_at = 10;
google.protobuf.Timestamp updated_at = 11;
string reason = 12;
}

// Resource contains information of resource from providers
Expand Down