Skip to content

feat(optimus): add backup detail rpc #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kushsharma merged 5 commits into from
Jan 4, 2022
Merged

feat(optimus): add backup detail rpc #66

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
87f326d
feat(optimus): add config field to BackupSpec
arinda-arif Nov 21, 2021
04c7026
feat(optimus): add GetBackupDetail rpc
arinda-arif Nov 22, 2021
489ba46
feat(optimus): add urn to backup details response
arinda-arif Nov 22, 2021
ddb8f3b
feat(optimus): add config field to ReplaySpec
arinda-arif Nov 25, 2021
ae233f3
refactor(optimus): treat backup as a resource
arinda-arif Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions odpf/optimus/runtime_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ service RuntimeService {
body: "*"
};
}
rpc Backup(BackupRequest) returns (BackupResponse) {
rpc CreateBackup(CreateBackupRequest) returns (CreateBackupResponse) {
option (google.api.http) = {
post: "/v1/project/{project_name}/namespace/{namespace}/datastore/{datastore_name}/backup"
body: "*"
Expand All @@ -221,6 +221,11 @@ service RuntimeService {
get: "/v1/project/{project_name}/namespace/{namespace}/datastore/{datastore_name}/backup"
};
}
rpc GetBackup(GetBackupRequest) returns (GetBackupResponse) {
option (google.api.http) = {
get: "/v1/project/{project_name}/namespace/{namespace}/datastore/{datastore_name}/backup/{id}"
};
}
// TODO(kush.sharma): disabled ATM
// rpc DeleteResource(DeleteResourceRequest) returns (DeleteResourceResponse) {}

Expand Down Expand Up @@ -782,6 +787,7 @@ message ReplaySpec {
google.protobuf.Timestamp end_date = 4;
string state = 5;
google.protobuf.Timestamp created_at = 6;
map<string, string> config = 7;
}

message RunJobRequest {
Expand Down Expand Up @@ -815,7 +821,7 @@ message BackupDryRunResponse {
repeated string ignored_resources = 2;
}

message BackupRequest {
message CreateBackupRequest {
string project_name = 1;
string datastore_name = 2;
string resource_name = 3;
Expand All @@ -830,7 +836,7 @@ message BackupRequest {
repeated string allowed_downstream_namespaces = 8;
}

message BackupResponse {
message CreateBackupResponse {
repeated string urn = 1;
repeated string ignored_resources = 2;
}
Expand All @@ -850,4 +856,17 @@ message BackupSpec {
string resource_name = 2;
google.protobuf.Timestamp created_at = 3;
string description = 4;
map<string, string> config = 5;
}

message GetBackupRequest {
string project_name = 1;
string datastore_name = 2;
string namespace = 3;
string id = 4;
}

message GetBackupResponse {
BackupSpec spec = 1;
repeated string urn = 2;
}