Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions odpf/assets/bucket.proto
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ option go_package = "github.com/odpf/proton/assets";
import "google/protobuf/timestamp.proto";

import "odpf/assets/facets/ownership.proto";
import "odpf/assets/facets/lineage.proto";
import "odpf/assets/facets/properties.proto";

import "odpf/assets/common/resource.proto";
Expand Down Expand Up @@ -66,19 +65,15 @@ message Blob {
// Example: `gcs`.
string source = 3;

// The description of the blob.
// Example: `This is a config file for x app`
string description = 4;

// The length of the object content.
// Example: `300`
int64 size = 5;
int64 size = 4;

// Delete time of the blob object.
google.protobuf.Timestamp delete_time = 6;
google.protobuf.Timestamp delete_time = 5;

// Expire time of the blob object.
google.protobuf.Timestamp expire_time = 7;
google.protobuf.Timestamp expire_time = 6;

// The ownership of the blob.
// For an example check out ownership.
Expand Down
4 changes: 4 additions & 0 deletions odpf/assets/common/resource.proto
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,8 @@ message Resource {
// The REST URL for accessing the resource. URL returns the resource itself.
// Example: `https://xyz.com/v1/users/user-123`
string url = 5;

// The description of the resource.
// Example: `This resource is being used for storing important number`
string description = 6;
}
10 changes: 5 additions & 5 deletions odpf/assets/dashboard.proto
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ message Dashboard {
// Representation of the resource
odpf.assets.common.Resource resource = 1;

// The description of the dashboard.
// Example: "This dashboard was created by the Metabase team."
string description = 4;

// The list of the charts in the dashboard.
// For an example, check the schema of the chart.
repeated Chart charts = 21;
Expand All @@ -39,6 +35,10 @@ message Dashboard {
// Timstamp facet can be used to set the creation and updation timestamp of a user.
odpf.assets.common.Timestamp timestamps = 33;

// The lineage of the dashboard.
// For an example check out lineage schema.
odpf.assets.facets.Lineage lineage = 34;

// The timestamp of the generated event.
// Event schemas is defined in the common event schema.
odpf.assets.common.Event event = 100;
Expand Down Expand Up @@ -90,7 +90,7 @@ message Chart {
// For an example check out ownership.
odpf.assets.facets.Ownership ownership = 31;

// The lineage of the dashboard.
// The lineage of the chart.
// For an example check out lineage schema.
odpf.assets.facets.Lineage lineage = 32;

Expand Down
2 changes: 1 addition & 1 deletion odpf/assets/group.proto
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ message Group {

// The email of the group.
// Example: `[email protected]`
string email = 3;
string email = 2;

// The members of the group.
// For example look at schema of the member.
Expand Down
4 changes: 0 additions & 4 deletions odpf/assets/job.proto
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ message Job {
// Representation of the resource
odpf.assets.common.Resource resource = 1;

// The description of the job.
// Example: 'This job is used to process data from a stream.'
string description = 5;

// The ownership of the topic.
// For an example check out ownership.
odpf.assets.facets.Ownership ownership = 31;
Expand Down
4 changes: 0 additions & 4 deletions odpf/assets/table.proto
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ message Table {
// Representation of the resource
odpf.assets.common.Resource resource = 1;

// The description of the table.
// Example: 'My User table'.
string description = 4;

// The metrics about the table.
// For example check the profile schem.
TableProfile profile = 21;
Expand Down
4 changes: 0 additions & 4 deletions odpf/assets/topic.proto
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ message Topic {
// Representation of the resource
odpf.assets.common.Resource resource = 1;

// The description of the topic.
// Example: 'This is a topic for my application'.
string description = 4;

// The metrics of the topic.
// For an example check out topic profile schema.
TopicProfile profile = 21;
Expand Down