fix: organization body in group #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravisuhag
reviewed
Nov 2, 2021
odpf/shield/v1/shield.proto
Outdated
| repeated User admins = 4; | ||
| int32 member_count = 5; | ||
| string org_id = 6; | ||
| // string OBSOLETE_org_id = 6; [OBSOLETE] |
Member
There was a problem hiding this comment.
@krtkvrm Since the shield GRPC version is not yet shipped. I think it is ok to make a breaking change and not reserve it.
Member
Author
There was a problem hiding this comment.
Had to add it as CI was showing Breaking Changes when I just replaced it with Organization organization = 6
Ref: https://github.com/odpf/proton/runs/4075364158?check_suite_focus=true#step:4:10
Member
There was a problem hiding this comment.
We can merge it irrespective of that. Lets also see if we can enable disable breaking change ci specific to certain projects.
AkarshSatija
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.