Skip to content

feat: add stencil search API #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ravisuhag merged 3 commits into from
Oct 1, 2021
Merged

feat: add stencil search API #47

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
774d3b6
feat: add search method to stencil
h4rikris Sep 22, 2021
491750b
refactor: stencil search result type
h4rikris Sep 29, 2021
c3c54d3
feat: group search results by file path
h4rikris Oct 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion odpf/stencil/v1/stencil.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,13 @@ service StencilService {
patch: "/v1/snapshots/{id}/promote"
};
}
// Search matches given query with message names and field names
// returns filtered message/field names along with snapshot details
rpc Search(SearchRequest) returns (SearchResponse) {
option (google.api.http) = {
get: "/v1/search"
};
}
}

enum Rule {
Expand Down Expand Up @@ -89,15 +96,35 @@ message UploadDescriptorResponse {
string errors = 3;
}

message ListSnapshotsRequest {
string namespace = 1;
string name = 2;
string version = 3;
bool latest = 4;
}

message ListSnapshotsResponse {
repeated Snapshot snapshots = 1;
}

message ListSnapshotsRequest {
message SearchRequest {
string namespace = 1;
string name = 2;
string version = 3;
bool latest = 4;
string query = 5;
}

message SearchResult {
string path = 1;
string package = 2;
repeated string messages = 3;
repeated string fields = 4;
repeated Snapshot snapshots = 5;
}

message SearchResponse {
repeated SearchResult results = 1;
}

message PromoteSnapshotRequest {
Expand Down