feat(optimus): add dryrun backup api path, request response model #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushsharma
reviewed
Sep 21, 2021
Member
kushsharma
left a comment
kushsharma
left a comment
There was a problem hiding this comment.
Why are files like odpf/optimus/cluster/command.proto and odpf/common/v1/service.proto shown as updated? I think the PR is not properly rebased?
arinda-arif
force-pushed
the
optimus-backup
branch
from
ed46a61 to
b658281
Compare
Contributor
Author
yes 👍 i have rebased it just now |
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding:
to support dry run backup feature in Optimus