feat: add common service with version endpoint to expose version and other info of the server #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…build info of the server
kushsharma
reviewed
Sep 5, 2021
Member
Author
|
@ravisuhag @AkarshSatija are we ok with service and package name |
kushsharma
reviewed
Sep 9, 2021
Member
Another one could be core? |
Member
|
LGTM 👍 I'll prefer |
kushsharma
approved these changes
Sep 9, 2021
rohilsurana
commented
Sep 9, 2021
| string commit = 2; | ||
| google.protobuf.Timestamp build_time = 3; | ||
| string lang_version = 4; | ||
| string os = 5; |
Member
Author
There was a problem hiding this comment.
what do we think about making some of these enums? Like OS and ARCH ?
Member
Author
There was a problem hiding this comment.
Was checking for different languages have different ways to denote os and arch, everyone will need to maintain mappings for the same. Hence letting these be of string type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this service is to act as a common way to expose version and build info of our services.
This will also house other common endpoints such as one to get server configurations.