Skip to content

refactor(optimus): update misconfigured api path for runtime_service.proto #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kushsharma merged 1 commit into from
Sep 8, 2021
Merged

refactor(optimus): update misconfigured api path for runtime_service.proto #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions odpf/optimus/runtime_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_swagger) = {
external_docs: {
description: "Optimus server";
}
schemes: HTTP;
schemes: HTTP;
host: "127.0.0.1:9100";
base_path: "/api";
};

// WARNING: This is still in active development and can have breaking changes
Expand Down Expand Up @@ -159,18 +161,21 @@ service RuntimeService {
};
}

// Datastore CRUD
// Database CRUD
// CreateResource registers a new resource of a namespace which belongs to a project
rpc CreateResource(CreateResourceRequest) returns (CreateResourceResponse) {
option (google.api.http) = {
post: "/v1/project/{project_name}/namespace/{namespace}/datastore/{datastore_name}/resource"
body: "*"
};
}
// ReadResource reads a provided resource spec of a namespace
rpc ReadResource(ReadResourceRequest) returns (ReadResourceResponse) {
option (google.api.http) = {
get: "/v1/project/{project_name}/namespace/{namespace}/datastore/{datastore_name}/resource/{resource_name}"
};
}
// UpdateResource updates a resource specification of a datastore in project
rpc UpdateResource(UpdateResourceRequest) returns (UpdateResourceResponse) {
option (google.api.http) = {
put: "/v1/project/{project_name}/namespace/{namespace}/datastore/{datastore_name}/resource"
Expand Down Expand Up @@ -200,7 +205,7 @@ service RuntimeService {
};
}
// TODO(kush.sharma): disabled ATM
//rpc DeleteResource(DeleteResourceRequest) returns (DeleteResourceResponse) {}
// rpc DeleteResource(DeleteResourceRequest) returns (DeleteResourceResponse) {}

}

Expand Down