Skip to content

fix(optimus): support multiple subquestion/answer at once in plugins #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kushsharma merged 1 commit into from
Jun 23, 2021
+8 −7
Merged

fix(optimus): support multiple subquestion/answer at once in plugins #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions odpf/optimus/runtime_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ service RuntimeService {
// CheckJobSpecifications checks if the job specifications are valid
rpc CheckJobSpecifications(CheckJobSpecificationsRequest) returns (stream CheckJobSpecificationsResponse) {}

// RegisterProject creates a new project
// RegisterProject creates a new optimus project
rpc RegisterProject(RegisterProjectRequest) returns (RegisterProjectResponse) {
option (google.api.http) = {
post: "/api/v1/project"
Expand Down Expand Up @@ -314,10 +314,6 @@ message VersionResponse {
message DeployJobSpecificationRequest {
string project_name = 1; // unique project identifier
repeated JobSpecification jobs = 2;

// TODO: not implemented yet, default behaviour is to treat this true always till then
// bool synchronize = 3; // deletes job that are not sent as part of this deployment

string namespace = 4;
}

Expand Down
9 changes: 7 additions & 2 deletions odpf/optimus/task_plugin.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,19 @@ message GetTaskSchema {
}

message PluginQuestion {
reserved 6, 7;

string name = 1;
string prompt = 2;
string help = 3;
string default = 4;
repeated string multiselect = 5;

string sub_questions_if_value = 6;
repeated PluginQuestion sub_questions = 7;
message SubQuestion {
string if_value = 1;
repeated PluginQuestion questions = 2;
}
repeated SubQuestion sub_questions = 8;
}

message PluginAnswer {
Expand Down