feat(compass): add asset, search, lineage, users, star, tags handlers #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@mabdh can you please check the lint issues reported by buf on compass proto. |
Member
Author
|
@ravisuhag yes there are some breaking changes with the main, how could we force the changes for compass proto? |
Member
It is fine to merge with these changes since we are yet to integrate and release the apis. But there are some more lint issues, which also we can fix. |
Member
Author
|
@ravisuhag right, there are some lint errors because we re-use a message in the different rpc services, e.g. |
mabdh
force-pushed
the
compass-assets-domain
branch
6 times, most recently
from
8a213c7 to
c3146a2
Compare
mabdh
force-pushed
the
compass-assets-domain
branch
from
c3146a2 to
c8ff339
Compare
mabdh
changed the title
mabdh
force-pushed
the
compass-assets-domain
branch
from
c8ff339 to
d2e6328
Compare
mabdh
force-pushed
the
compass-assets-domain
branch
from
d2e6328 to
7b6fd2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.