Skip to content

feat(optimus): add ability to delete secret for a project #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbchaos merged 4 commits into from
Feb 28, 2022
Merged

feat(optimus): add ability to delete secret for a project #104

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7581c3
feat: add ability to delete secret for a project
sbchaos Feb 21, 2022
3cd36d4
feat: add namespace_name for proxy authentication
sbchaos Feb 25, 2022
19418f6
feat: add ability to delete secret for a project
sbchaos Feb 21, 2022
e4282a9
Merge branch 'main' into delete-secret
sbchaos Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions odpf/optimus/core/v1beta1/runtime.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,13 @@ service RuntimeService {
};
}

// DeleteSecret deletes a secret for a project
rpc DeleteSecret(DeleteSecretRequest) returns (DeleteSecretResponse) {
option (google.api.http) = {
delete: "/v1beta1/project/{project_name}/secret/{secret_name}"
};
}

// ListProjects returns list of registered projects and configurations
rpc ListProjects(ListProjectsRequest) returns (ListProjectsResponse) {
option (google.api.http) = {
Expand Down Expand Up @@ -604,6 +611,14 @@ message ListSecretsResponse {
repeated Secret secrets = 1;
}

message DeleteSecretRequest {
string project_name = 1;
string secret_name = 2;
string namespace_name = 3;
}

message DeleteSecretResponse {}

message ListProjectsRequest {}

message ListProjectsResponse {
Expand Down