Skip to content

refactor: register instance api path for runtime_service.proto #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kushsharma merged 1 commit into from
Jun 3, 2021
Merged

refactor: register instance api path for runtime_service.proto #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions odpf/optimus/runtime_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ service RuntimeService {
// RegisterInstance is an internal admin command used during task execution
rpc RegisterInstance(RegisterInstanceRequest) returns (RegisterInstanceResponse) {
option (google.api.http) = {
post: "/api/v1/instance"
post: "/api/v1/project/{project_name}/job/{job_name}/instance"
body: "*"
};
}
Expand Down Expand Up @@ -167,7 +167,7 @@ service RuntimeService {
body: "*"
};
}
// TODO(kush.sharma): unsupported ATM
// TODO(kush.sharma): disabled ATM
//rpc DeleteResource(DeleteResourceRequest) returns (DeleteResourceResponse) {}

}
Expand Down