Skip to content

Conversation

@arinda-arif
Copy link
Contributor

Add replay list sub command to get list of recent replays per project.

Usage:
optimus replay list --project [project_name]

@coveralls
Copy link

coveralls commented Aug 23, 2021

Pull Request Test Coverage Report for Build 1216301092

  • 52 of 54 (96.3%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 69.948%

Changes Missing Coverage Covered Lines Changed/Added Lines %
api/handler/v1/runtime.go 35 37 94.59%
Totals Coverage Status
Change from base Build 1215937040: 0.1%
Covered Lines: 4292
Relevant Lines: 6136

💛 - Coveralls

@arinda-arif arinda-arif linked an issue Aug 23, 2021 that may be closed by this pull request
@arinda-arif arinda-arif requested a review from kushsharma August 23, 2021 04:28
@arinda-arif
Copy link
Contributor Author

@kushsharma i have pushed all the changes, however we still have unresolved discussion on proton. I will revert the makefile changes in here after those resolved and merged

@arinda-arif arinda-arif force-pushed the replay-list branch 2 times, most recently from 860e5d2 to 210d50e Compare August 25, 2021 09:54
@arinda-arif arinda-arif marked this pull request as draft August 25, 2021 10:14
@arinda-arif arinda-arif marked this pull request as ready for review September 6, 2021 09:51
@arinda-arif
Copy link
Contributor Author

@kushsharma I have rebased, updated the proto commit, and regenerated proto.

@kushsharma
Copy link
Member

LGTM

@arinda-arif arinda-arif merged commit 86c3e9b into main Sep 13, 2021
@arinda-arif arinda-arif deleted the replay-list branch September 13, 2021 04:26
@ravisuhag ravisuhag mentioned this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show recent replay list of a project

5 participants