-
Notifications
You must be signed in to change notification settings - Fork 154
feat: add replay list sub command #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1216301092
💛 - Coveralls |
kushsharma
requested changes
Aug 23, 2021
Contributor
Author
|
@kushsharma i have pushed all the changes, however we still have unresolved discussion on proton. I will revert the makefile changes in here after those resolved and merged |
860e5d2 to
210d50e
Compare
ravisuhag
reviewed
Aug 25, 2021
kushsharma
reviewed
Sep 6, 2021
kushsharma
reviewed
Sep 6, 2021
Contributor
Author
|
@kushsharma I have rebased, updated the proto commit, and regenerated proto. |
kushsharma
reviewed
Sep 8, 2021
8c19f89 to
08bc3a9
Compare
08bc3a9 to
20c62a4
Compare
8b10f28 to
b543705
Compare
kushsharma
approved these changes
Sep 12, 2021
Member
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add replay list sub command to get list of recent replays per project.
Usage:
optimus replay list --project [project_name]