Skip to content

Conversation

@kushsharma
Copy link
Member

@kushsharma kushsharma commented Jul 5, 2021

  • Added support for Failure hook point

@coveralls
Copy link

coveralls commented Jul 5, 2021

Pull Request Test Coverage Report for Build 1025198576

  • 298 of 452 (65.93%) changed or added relevant lines in 8 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.05%) to 66.424%

Changes Missing Coverage Covered Lines Changed/Added Lines %
job/compiler.go 13 16 81.25%
store/local/job_spec_adapter.go 45 49 91.84%
job/event.go 26 32 81.25%
ext/notify/slack/slack.go 162 198 81.82%
api/handler/v1/runtime.go 23 128 17.97%
Files with Coverage Reduction New Missed Lines %
api/handler/v1/runtime.go 5 44.06%
Totals Coverage Status
Change from base Build 1015504215: 2.05%
Covered Lines: 3745
Relevant Lines: 5638

💛 - Coveralls

@kushsharma kushsharma force-pushed the slack-alerts branch 10 times, most recently from 0435fa7 to 7cd4454 Compare July 8, 2021 10:32
@mauliksoneji
Copy link
Member

Please rebase the branch against current main

@kushsharma kushsharma force-pushed the slack-alerts branch 2 times, most recently from 1d2e660 to 1d6b14f Compare July 12, 2021 12:00
@kushsharma
Copy link
Member Author

Please rebase the branch against current main

Done @mauliksoneji

@kushsharma kushsharma merged commit 987d7d9 into main Jul 13, 2021
@ravisuhag ravisuhag deleted the slack-alerts branch July 21, 2021 18:16
@ravisuhag ravisuhag mentioned this pull request Jul 20, 2023
turtleDev pushed a commit that referenced this pull request Jun 8, 2024
* docs: adding documentation for REST and gRPC endpoint

Added documentation for supporting JSON with websocketrs too

* docs:

Fixed typo in architecture doc

* docs: adding table for supported protocols and formats

* perf(websockets): performance optimisation after load tests

- change collection channel from pointer to non-pointer struct
- make the channel buffered

* perf(websockets): remove closures from codebase

remove closures from codebase because of performace implications
following packages are impacted:
- http/websockets
- http/rest
- http
- serialization
- deserialization

* perf(WebSockets): Removed Identifier Pointer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants