feat: add backup detail and refactor backup #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arinda-arif
commented
Nov 23, 2021
arinda-arif
commented
- change bigquery backup result table name to use timestamp suffix
- add extra information in backup list
- add backup detail sub command
Pull Request Test Coverage Report for Build 1652456122
💛 - Coveralls |
arinda-arif
force-pushed
the
backup-detail
branch
from
9c27e53 to
0826f63
Compare
Member
arinda-arif
force-pushed
the
backup-detail
branch
from
4715039 to
9a6a222
Compare
Contributor
Author
|
Hi @kushsharma, this PR is ready to be reviewed. Need your help on this 🙂 |
kushsharma
requested changes
Dec 20, 2021
api/handler/v1/runtime.go
Outdated
| if !ok { | ||
| return nil, status.Errorf(codes.Internal, "error while parsing backup result: %v", ok) | ||
| } | ||
| results = append(results, backupResult[models.BackupSpecKeyURN].(string)) |
Member
There was a problem hiding this comment.
What if models.BackupSpecKeyURN doesn't exist in the backupResult? If it didn't, it will be casted as nil because map kv pair value is of type interface and interface default value will be nil. What if it exists and it can't be cast to string? Both of them will panic and crash the application right?
Contributor
Author
There was a problem hiding this comment.
I have added 2 error catch:
- if
models.BackupSpecKeyURNdoesn't exist in the map - if the value cannot be casted to string
Please check if it is proper enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.