refactor: use generic handling for getting/setting attributes #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type specific handling has a good chance of becoming outdated if and when new attribute types are introduced. Address with following: - Use type assertion on generic proto message to check for the presence of attributes field for retrieving as map. - Use Go reflection to find the field by name and set value to new attributes created using given map.
sudo-suhas
force-pushed
the
generic-attributes-handling
branch
from
22a7d26 to
341de71
Compare
StewartJingga
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type specific handling has a good chance of becoming outdated if and when new attribute types are introduced. Address with following: