Skip to content

feat(bigquery): use service_account_base64 to pass credentials #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bsushmith merged 6 commits into from
Nov 15, 2022
Merged

feat(bigquery): use service_account_base64 to pass credentials #438

bsushmith merged 6 commits into from
Nov 15, 2022

Conversation

@bsushmith
Copy link
Member

@bsushmith bsushmith commented Nov 15, 2022 •
edited
Loading

  • use service_account_base64 config that will take precedence over service_account_json in bigquery extractor

Closes #424

@bsushmith
feat(bigquery): use service_account_base64 to pass credentials
94f247d 
* use `service_account_base64` config that will take precedence over service_account_json in bigquery extractor
@bsushmith
docs: fix incorrect config in readme
acf78b0
@bsushmith
docs: update readme with new config field
b8717b4
@bsushmith bsushmith linked an issue Nov 15, 2022 that may be closed by this pull request
use base64 encoded instead of service account string directly in bigquery extractor #424
Closed
sudo-suhas
sudo-suhas requested changes Nov 15, 2022
View reviewed changes
@bsushmith bsushmith requested a review from sudo-suhas November 15, 2022 12:06
sudo-suhas
sudo-suhas approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@sudo-suhas sudo-suhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudo-suhas
Copy link
Contributor

sudo-suhas commented Nov 15, 2022

Please set an appropriate commit message while merging 🙏🏼

Not much value of including each commit's message. (ex: * lint: fix lint formatting)

@bsushmith bsushmith merged commit dc6567b into main Nov 15, 2022
@bsushmith bsushmith deleted the 424-sa-base64 branch November 15, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sudo-suhas sudo-suhas sudo-suhas approved these changes

@singhvikash11 singhvikash11 singhvikash11 approved these changes

@StewartJingga StewartJingga Awaiting requested review from StewartJingga

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

use base64 encoded instead of service account string directly in bigquery extractor

4 participants

@bsushmith @sudo-suhas @singhvikash11