refactor: add decode hook function for anypb in structmap #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-suhas
force-pushed
the
structmap-map-to-any
branch
2 times, most recently
from
e6658ac to
df0aef8
Compare
- Eliminate the need for special handling of asset proto by introducing the decode hook function for anypb type. - Instantiate concrete type for the anypb field using the @type field in given map. This makes it possible into an empty asset proto. - Verify data type and presense of data field in given map while decoding into an asset proto. - Remove unused type structmap.AssetWrapper. Port the tests for it into structmap_test.go.
sudo-suhas
force-pushed
the
structmap-map-to-any
branch
from
df0aef8 to
b59784b
Compare
StewartJingga
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@typefield in given map. This makes it possible into an empty asset proto.