ci: enable cache to speed up jobs #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-suhas
force-pushed
the
ci-go-cache
branch
3 times, most recently
from
630b78b to
da13fb0
Compare
- Bump Go version {1.17 => 1.18}.
- Ensure to fetch the latest version in 'build' and 'release'
workflows to pull in the most up-to-date release so that security
fixes can be included.
- Bump the golangci-lint version {v1.42.1 => v1.50}. This is required
to be able to lint source code with Go 1.18. Fails with 'undeclared
name' errors otherwise.
- Do not run 'go mod tidy' as this can modify the mod file. Changes to
dependencies should be explicitly committed where required.
- Modify release workflow as per
https://goreleaser.com/ci/actions/#workflow.
- Bump action versions:
- actions/setup-go@{v2 => v3}. Enable the 'cache' option for caching
dependency files and build outputs.
- actions/checkout@{v2 => v3}.
- golangci/golangci-lint-action@{v2 => v3}. Caching is enabled by
default. Bump golangci-lint version {v1.42.1 => v1.50}, needed for
Go 1.18.
- Fix linting issues due to deprecation of ioutil package. Migrate to io
and os packages instead.
- Consistent formatting:
- Checkout code first in all jobs across workflows with the name
'Checkout code'.
- Setup Go after 'Checkout code' with the name 'Set up Go'.
sudo-suhas
force-pushed
the
ci-go-cache
branch
from
da13fb0 to
24b2fde
Compare
Contributor
Author
Before
(sample CI run from #432) After
|
StewartJingga
approved these changes
Nov 7, 2022
Contributor
StewartJingga
left a comment
StewartJingga
left a comment
There was a problem hiding this comment.
Nice @sudo-suhas 🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workflows to pull in the most up-to-date release so that security
fixes can be included.
to be able to lint source code with Go 1.18. Fails with 'undeclared
name' errors otherwise.
dependencies should be explicitly committed where required.
https://goreleaser.com/ci/actions/#workflow.
dependency files and build outputs.
default. Bump golangci-lint version {v1.42.1 => v1.50}, needed for
Go 1.18.
and os packages instead.
'Checkout code'.