feat: add application_yaml extractor #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-suhas
force-pushed
the
service_yaml-extractor
branch
from
04f8605 to
bc44298
Compare
ravisuhag
reviewed
Nov 4, 2022
sudo-suhas
force-pushed
the
service_yaml-extractor
branch
from
bc44298 to
7010a36
Compare
sudo-suhas
force-pushed
the
service_yaml-extractor
branch
from
7010a36 to
7566e48
Compare
sudo-suhas
changed the title
sudo-suhas
force-pushed
the
service_yaml-extractor
branch
from
7566e48 to
93aa0cc
Compare
sudo-suhas
commented
Nov 4, 2022
sudo-suhas
force-pushed
the
service_yaml-extractor
branch
from
93aa0cc to
5dd5081
Compare
sudo-suhas
force-pushed
the
service_yaml-extractor
branch
2 times, most recently
from
ade27ac to
618d504
Compare
Contributor
Author
|
@StewartJingga do you want to take a final look or shall I go ahead and merge this in? |
- Add application_yaml extractor for reading the given YAML file and emitting an Asset of type service. - Fix relative link to contributing guide in plugin READMEs. - Remove unused code in utils/config.go - Move private helper functions in caramlstore extractor to plugin pkg for - parsing Kafka scope from bootstrap servers - constructing URN from BigQuery table's fully qualified name.
sudo-suhas
force-pushed
the
service_yaml-extractor
branch
from
618d504 to
94ce1b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DONE]
Needs raystack/proton#214 to be merged first (updatePROTON_COMMITin the Makefile after that)